It's a rhetorical question. Of course they should. It's terribly sad how anyone can maintain a relationship when one party is constantly threatening with suicide whenever things don't go their way.
There's nothing there to salvage. Just do both of yourselves a favor and break up. Seriously. It's the best thing that can happen to both of you.